Uploaded image for project: 'SignServer'
  1. SignServer
  2. DSS-1968

OpenPGP signer should not be active if the key does not exist

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.0.Alpha1, 5.1.0.Final
    • Component/s: None
    • Labels:
      None
    • Epic Link:
    • Sprint:
      SignServer-Sprint 99

      Description

      Broken out of DSS-976:

      Currently the OpenPGPSigner overrides isNoCertificates() and always returns true, as the signer does not need any certificates. However, this also bypasses all the key checks which means that the worker is active even if the key does not exist.

      Maybe we need to implement the key-checks that is otherwise performed in one of the base classes, directly in OpenPGPSigner.getStatus() or similar.

      The worker should be offline if the key does not exist.

      The worker should preferably also be offline if the PGPPUBLICKEY does not match the key in the token.

      The worker should probably also to the key usage checks and any other appropriate checks from the base class (just not requiring there to be a non-dummy-cert installed).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markus Markus Kilås
              Reporter:
              markus Markus Kilås
              Verified by:
              Marcus Lundblad
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 3 hours
                  3h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 37 minutes Time Not Required
                  1h 37m