Uploaded image for project: 'EJBCA'
  1. EJBCA
  2. ECA-6377

Move profile ID constants into the correct classes

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EJBCA 6.11.0
    • Component/s: None
    • Labels:
    • Issue discovered during:
      Review
    • Sprint:
      EJBCA Sprint 4

      Description

      Currently, there are at least four constants:
      EndEntityInformation.NO_ENDENTITYPROFILE
      EndEntityInformation.NO_CERTIFICATEPROFILE
      SecConst.PROFILE_NO_PROFILE
      SecConst.EMPTY_ENDENTITYPROFILE

      There are also mismatches in the Javadoc. See the review comments in CR-EJBCA-2038

      In my own opinion, it would make most sense to have these in EndEntityProfile and CertificateProfile classes, or maybe in SecConst (which has a lot of constants already).

      And there should be different constants for end entity profiles and certificate profiles, because now it's hard to tell what a "PROFILE_NO_PROFILE" means in the code.

      These constants are used in a lot of places (and there might also be some places where a literal 0 is still being used), but it is mostly simple "search and replace" work.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                realiserad Bastian Fredriksson
                Reporter:
                samuel Samuel Lidén Borell
                Verified by:
                Samuel Lidén Borell
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 hours Original Estimate - 2 hours
                  2h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours
                  3h