Uploaded image for project: 'EJBCA'
  1. EJBCA
  2. ECA-7317

SCEP error messages when CA can not be found are not complete

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EJBCA 7.0.0
    • Component/s: None
    • Labels:
      None
    • Issue discovered during:
      Customer
    • Sprint:
      EJBCA Sprint 20

      Description

      SCEP error message in code when a CA can not be found for GetCACert messages are:

      String errMsg = intres.getLocalizedMessage("scep.errorunknownca", "cert");
      log.error(errMsg);

       

      Which results in a message:

      10:49:00,145 ERROR [org.ejbca.ui.web.protocol.ScepServlet] (http-0.0.0.0:8080-4) SCEP cert request for unknown CA ''.

      "scep.errorunknownca" actually has more to give:

      scep.errorunknownca = SCEP {0} request for unknown CA '{1}'.

       

      So it could say:

      10:49:00,145 ERROR [org.ejbca.ui.web.protocol.ScepServlet] (http-0.0.0.0:8080-4) SCEP getCACert request for unknown CA 'foo'.

       which is a better error message. This is also logged at error level, which is wrong. It's a "normal" handling of bad input, so it should be logged at info level.

      (error level is for fatal errors that should cause monitoring systems to give alert)

       

        Attachments

          Activity

            People

            • Assignee:
              tomas Tomas Gustavsson
              Reporter:
              tomas Tomas Gustavsson
              Verified by:
              Henrik Sunmark
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Time Spent - 30 minutes Remaining Estimate - 30 minutes
                30m
                Logged:
                Time Spent - 30 minutes Remaining Estimate - 30 minutes
                30m