Uploaded image for project: 'EJBCA'
  1. EJBCA
  2. ECA-7492

Fun refactoring task - WebLanguages class uses property arrays, but should be remade in more OOP way

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EJBCA 7.0.0
    • Component/s: CA GUI, RA UI
    • Labels:
    • Sprint:
      EJBCA Team Alice - 2018 w48, EJBCA Team Alice - 2018 w51, EJBCA Team Alice - 2019 w2

      Description

      currently, when you look at the usage of WebLanguages class, the UI components first call

      getLanguagesEnglishNames() and getLanguagesNativeNames() methods

      and then composes the UI 'language' elements relying on those lists being ordered exactly the same way.

      More "OOP" way would be to have a Language class, that itself knows its native name and english name and shorthand and perhaps also overwrites its toString() method to provide a 'UI name' for itself.

       

      IMO A good candidate for our workshops' pairprogramming excercises.

        Attachments

          Activity

            People

            Assignee:
            laurik_helmes Lauri Kongas
            Reporter:
            tarmo_helmes Tarmo Raudsep (Inactive)
            Verified by:
            Henrik Sunmark
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 6 hours Original Estimate - 6 hours
                6h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 15 minutes
                1d 2h 15m