Uploaded image for project: 'EJBCA'
  1. EJBCA
  2. ECA-7795

Clean up Crypto Token code in Edit CA page

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: EJBCA 7.0.0
    • Fix Version/s: None
    • Component/s: CA GUI
    • Labels:
    • Provenance:
      Refactorization
    • Issue discovered during:
      Another issue

      Description

      The Crypto Token code in the Edit CA page can be simplified and improved:

      1. Remove the redundant cryptoTokenIdParam variable. JSF can handle Integers so it is not needed.
      2. Check for missing Crypto Token in initEditCaPage() instead of getAvailableCryptoTokensList
      3. The available Crypto Tokens should be stored in an instance variable and only loaded at page initialization and when changing signature algorithm. Currently, it is loaded several times.
      4. rendered="..." expressions for key aliases are all the same and could use one getter for this purpose, rather than "X and Y and Z"

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                samuel Samuel Lidén Borell
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 1 day
                  1d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified