Uploaded image for project: 'EJBCA'
  1. EJBCA
  2. ECA-8466

ACME test suite re-factorings

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Cosmetic
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EJBCA 7.3.0
    • Component/s: Protocols
    • Labels:
      None

      Description

      • Include AcmeJsonHelperRequestUnitTest and AcmeJsonHelperResponseUnitTest into ACME test suite.
      • Remove code duplications in system tests (children of AcmeSystemTestBase, i.e. for account and order creation, may be more).
      • Replace string values with their AcmeProblem objects.
      • Assert as early as possible.
      • Make sure test data is cleaned up if a test breaks, i.e. AcmeOrderDataSessionSystemTest or EE under the ManagementCA.
      • Improve grouping ACME end point tests in AcmeWorkflowSystemTest and AcmeConfigurationAndValidationSystemTest, i.e.: DNS challenges are testet in the first one, failures in the latter one, etc. See AcmeWorkflowSystemTest as goal.
      • factor out DER certificate download from AcmeConfigurationAndValidationSystemTest.leaveRevocationReasonUnchanged to AcmeWorkflowSystemTest.
      • use TestWatcher to trace test method name beginning and finish.

        Attachments

          Activity

            People

            Assignee:
            anjakobs Andres Jakobs
            Reporter:
            anjakobs Andres Jakobs
            Verified by:
            Henrik Sunmark
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: